sortlistmodel: Actually insert unsorted items at the wrong place
authorBenjamin Otte <otte@redhat.com>
Mon, 17 Sep 2018 01:50:56 +0000 (03:50 +0200)
committerBenjamin Otte <otte@redhat.com>
Mon, 17 Sep 2018 01:57:37 +0000 (03:57 +0200)
We were adding items in reverse order, oops.

gtk/gtksortlistmodel.c

index f8561cde8d2d553b9904ce1da84604207774f0b3..f127791ebc186b97c03f5ab63a835831494c938a 100644 (file)
@@ -174,7 +174,7 @@ gtk_sort_list_model_add_items (GtkSortListModel *self,
     {
       gpointer item = g_list_model_get_item (self->model, position + i);
       sorted_iter = g_sequence_insert_sorted (self->sorted, item, self->sort_func, self->user_data);
-      unsorted_iter = g_sequence_insert_before (unsorted_iter, sorted_iter);
+      g_sequence_insert_before (unsorted_iter, sorted_iter);
       if (unmodified_start != NULL || unmodified_end != NULL)
         {
           pos = g_sequence_iter_get_position (sorted_iter);
@@ -186,7 +186,7 @@ gtk_sort_list_model_add_items (GtkSortListModel *self,
   if (unmodified_start)
     *unmodified_start = start;
   if (unmodified_end)
-  *unmodified_end = end;
+    *unmodified_end = end;
 }
 
 static void